On Tue, 7 May 2024 at 17:52, Ross Burton <[email protected]> wrote:
> If you send a v3, this can be Backport. :)
I'm leaning towards addressing the review comments with followup
patches. None is a critical fix needed for update itself. You ok with
that?
> > +EXTRA_OEMESON:append:class-target = " ${@'-Dgir_dir_prefix=${libdir}' if
> > d.getVar('MULTILIBS') else ''}"
>
> Why does this need to be conditional?
This is a direct copy-paste from g-i recipe. g-i (before) and glib
(now) install gir files into /usr/share by default which doesn't work
for multilib because they differ between 32 and 64 bit targets, and
package manager errors out.
> > # setuptools can be removed when upstream removes all uses of distutils
> > -RDEPENDS:${PN} = "python3-pickle python3-xml python3-setuptools"
> > +RDEPENDS:${PN} = "python3-pickle python3-xml python3-setuptools glib-2.0”
>
> Is setuptools still needed? If so, might be worth calling out what the exact
> user is because a simple grep doesn’t find any users.
Indeed, neither distutils nor setuptools are anywhere in 2.80.0 tree.
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#199105):
https://lists.openembedded.org/g/openembedded-core/message/199105
Mute This Topic: https://lists.openembedded.org/mt/105860089/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
