Thanks for fixing this, however I would also suggest to submit this upstream and see if this is acceptable
On Mon, Apr 29, 2024 at 3:30 AM Zoltan Boszormenyi via lists.openembedded.org <[email protected]> wrote: > > GCC 14 implicitly turns a warning into a compiler error: > > | ../../git/src/lib/packlib.c: In function ‘PWClose’: > | ../../git/src/lib/packlib.c:554:40: error: passing argument 1 of > ‘HwmsHostToBigEndian’ from incompatible pointer type > [-Wincompatible-pointer-types] > | 554 | HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), > en_is32); > | | ~~~~~~~^~~~~ > | | | > | | uint32_t * {aka unsigned int > *} > | ../../git/src/lib/packlib.c:142:27: note: expected ‘char *’ but argument is > of type ‘uint32_t *’ {aka ‘unsigned int *’} > | 142 | HwmsHostToBigEndian(char *pHwms, int nLen,int nBitType) > | | ~~~~~~^~~~~ > > Add the cast to (char *) to silence it. > > Signed-off-by: Zoltán Böszörményi <[email protected]> > --- > ...0001-packlib.c-support-dictionary-byte-order-dependent.patch | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch > > b/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch > index 20572b55c4..35229ae890 100644 > --- > a/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch > +++ > b/meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch > @@ -303,7 +303,7 @@ index 9396e1d..d0bb181 100644 > + PWDICT tmp_pwp; > + > + memcpy(&tmp_pwp, pwp, sizeof(PWDICT)); > -+ HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32); > ++ HwmsHostToBigEndian((char *)tmp_pwp.hwms, sizeof(tmp_pwp.hwms), > en_is32); > + fwrite(tmp_pwp.hwms, 1, sizeof(tmp_pwp.hwms), pwp->wfp); > } > } > -- > 2.44.0 > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#198744): https://lists.openembedded.org/g/openembedded-core/message/198744 Mute This Topic: https://lists.openembedded.org/mt/105797819/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
