Correction: they didn't rewrite it, they just moved around the lines: https://github.com/python/cpython/commit/9084e1b04f8d35721b535a3acd550b920d50f11a and I didn't look thoroughly enough for the new location.
Neverthless, given that a-full still passed with the patch removed means pgo can be completely broken or completely working, and we would have no idea. I lean towards 'completely broken' but I'll reinstate the patch. Alex On Thu, 14 Dec 2023 at 14:49, Alexander Kanavin via lists.openembedded.org <[email protected]> wrote: > > FWIW in the upcoming python 3.12 update I have removed the pgo patch > (0001-Makefile.pre-use-qemu-wrapper-when-gathering-profile.patch) with > the rationale that "pgo support has been rewritten upstream and needs > to be reenabled and tested separately". I simply don't have bandwidth > to make it work, with a ton of recipes in meta-oe that still need > fixing with 3.12. > > Alex > > On Thu, 14 Dec 2023 at 14:35, Richard Purdie > <[email protected]> wrote: > > > > On Thu, 2023-12-14 at 13:31 +0000, Ross Burton wrote: > > > On 14 Dec 2023, at 07:49, Alexandre Belloni > > > <[email protected]> wrote: > > > > Not obvious but this is the cause of: > > > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/20/builds/8697 > > > > > > That was a fun rabbithole to dig. > > > > > > The error from the log is: > > > > > > ERROR: /home/pokybuild/yocto-worker/buildtools/build/meta/recipes- > > > devtools/python/python3_3.11.5.bb: pgo cannot be enabled as there is > > > no qemu-usermode support for this architecture/machine > > > > > > Which was intentional fallout: MACHINE_FEATURES don’t describe the > > > SDK so that this ever worked was more luck than judgement. Also the > > > python3 recipe will write the qemu-calling wrapper script using the > > > architecture only for target builds, so we’ve not had PGO nativesdk > > > python since the 3.7.2 upgrade in 2019[1] which changed this from all > > > builds to target only. > > > > > > Maybe we should allow machine-sdk configurations to extend > > > SDK_MACHINE_FEATURES and then nativesdk can use that? This might > > > allow the MACHINE_FEATURES to “work” without being based on the > > > target machine. > > > > Sadly I suspect we're going to have to go down this route eventually in > > some form. > > > > > Alternatively, I can remove the pgo from the buildtools build, as it > > > doesn’t actually do anything right now anyway. > > > > It was a decent win at one point so that would seem sad. > > > > Cheers, > > > > Richard > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#192382): https://lists.openembedded.org/g/openembedded-core/message/192382 Mute This Topic: https://lists.openembedded.org/mt/103129922/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
