On Fri, 2023-11-10 at 22:17 +0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: [email protected] > > <[email protected]> On Behalf Of Patchtest > > Sent: den 9 november 2023 00:10 > > To: Steve Sakoman <[email protected]> > > Cc: [email protected] > > Subject: Patchtest results for [OE-core][kirkstone 5/7] cve-check: > > slightly more verbose warning when adding the same package twice > > > > Thank you for your submission. Patchtest identified one > > or more issues with the patch. Please see the log below for > > more information: > > > > --- > > Testing patch /home/patchtest/share/mboxes/kirkstone-5-7-cve-check- > > slightly-more-verbose-warning-when-adding-the-same-package- > > twice.patch > > > > FAIL: test shortlog length: Edit shortlog so that it is 90 > > characters or less (currently 91 characters) > > (test_mbox.TestMbox.test_shortlog_length) > > I find it extremely confusing that this test refers to "shortlog". > I had to go check the code to see what it was actually testing. > It seems it is actually the "commit subject" that is being tested. > > Can we please change this and other tests that refer to "shortlog" > to either use "commit subject" (in messages) or "subject" (in > names)? > > Also, it seems the test incorrectly includes the "[kirkstone 5/7]" > part in the tested length.
The code is here: https://git.yoctoproject.org/poky/tree/meta/lib/patchtest/tests/test_mbox.py#n83 so patches very welcome. Part of the work was to make these tests more accessible so we can all work on and improve them. shortlog is technically correct since this does become the shortlog in the git commit so I'd prefer to keep that but we can mention message subject as well. We should also definitely strip off the [] sections before calculating the length. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#190411): https://lists.openembedded.org/g/openembedded-core/message/190411 Mute This Topic: https://lists.openembedded.org/mt/102475465/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
