On Fri, Sep 8 2023 at 03:43:49 PM +02:00:00, Alexander Kanavin <[email protected]> wrote:
Is it super hard to patch epiphany so that libadwaita is optional?

I don't think that this is possible with gtk4

I'm fine with splitting the patch if needed, but I believe that both of the changes are inappropriate for upstream use.

The patch renames ascli_exe command to appstreamcli so that it differs from the one that is used for the target binary.

This only works, because we define appstreamcli from a meson.cross file:

do_write_config:append:class-target() {
   cat >${WORKDIR}/meson-${PN}.cross <<EOF
[binaries]
appstreamcli = '${STAGING_BINDIR_NATIVE}/appstreamcli'
EOF
}

This won't work upstream like this.

I also think, the second change would break build for a lot of people because the hardcoded include path surely is there for a reason,
even though it breaks the yocto build.
.
Probably the reason is that the buildsystem of snowball is bitrotten and also has no pkgconfig support.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187435): 
https://lists.openembedded.org/g/openembedded-core/message/187435
Mute This Topic: https://lists.openembedded.org/mt/101235781/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to