Yeah, I have just checked it for acpid-src packages and diffoscope worked without any errors.
Question, is this test being run with acl or/and xattr? Because from what I remember it was not. Can you check? If this will confirm, then something is still wrong with the gnu format, because right now all posix - meaning with acl/xattr support - packages are working for me. BR Piotr ________________________________ Od: [email protected] <[email protected]> w imieniu użytkownika Piotr Łobacz via lists.openembedded.org <[email protected]> Wysłane: wtorek, 25 lipca 2023 11:40 Do: Alexandre Belloni <[email protected]> DW: [email protected] <[email protected]> Temat: ODP: ODP: [OE-Core][PATCH v10][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Hmmm, this is odd because yesterday I have checked this and the additional parameters added to tar have fixed the issue for me. But I have added them only for posix tar format, because for gnu format there is no need. BTW. only these packages are different? AssertionError: The following ipk packages are different and not in exclusion list: /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/acpid-src_2.0.34-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/avahi-src_0.8-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/bind-src_9.18.16-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/debugedit-src_5.0-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/flac-src_1.4.3-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/libjson-glib-1.0-dev_1.6.6-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/libjson-glib-1.0-ptest_1.6.6-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/libjson-glib-1.0-src_1.6.6-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/libmnl-src_1.0.5-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/libuuid-src_2.38.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/log4cplus-src_2.1.0-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/lttng-tools-src_2.13.9-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/python3-numpy-src_1.25.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/python3-pygobject-dev_3.44.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/python3-pygobject-src_3.44.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/python3-pygobject_3.44.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/util-linux-ptest_2.38.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/util-linux-src_2.38.1-r0_core2-64.ipk /home/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB/tmp/deploy/ipk/./core2-64/webkitgtk-src_2.40.2-r0_core2-64.ipk Od: Alexandre Belloni <[email protected]> Wysłane: wtorek, 25 lipca 2023 11:28 Do: Piotr Łobacz <[email protected]> DW: [email protected] <[email protected]> Temat: Re: ODP: [OE-Core][PATCH v10][master-next 1/5] package_ipk.bbclass: add support for ACLs and xattr Hello Piotr, On 24/07/2023 20:50:50+0000, Piotr Łobacz wrote: > > Hello Alexandre, > this is a final patchest which works for me, even with reproducible builds, > but additionally, with posix format of tar archives. > > I hope that this time it will work for autobuild as well. We are almost there, there are still reproducibility failures which I guess where hidding in all the other other ones: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yoctoproject.org%2Ftyphoon%2F%23%2Fbuilders%2F117%2Fbuilds%2F3251%2Fsteps%2F12%2Flogs%2Fstdio&data=05%7C01%7Cp.lobacz%40welotec.com%7C591c597fa0a04e4ecb3f08db8cf340eb%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638258748639032081%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XVprHSXzRygzFvdXHDDhEKLrqC%2FSN%2FC3Q8%2FyqNF2jE0%3D&reserved=0<https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/3251/steps/12/logs/stdio> This time, diffoscope ran: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fautobuilder.yocto.io%2Fpub%2Frepro-fail%2Foe-reproducible-20230724-5av30jl8%2Fpackages%2Fdiff-html%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C591c597fa0a04e4ecb3f08db8cf340eb%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638258748639032081%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3ml4mQptghh889Urap%2BC5y%2BZKhzHXc7rV2anf7bQas4%3D&reserved=0<https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20230724-5av30jl8/packages/diff-html/> > > BR > Piotr > > Od: Piotr Łobacz <[email protected]> > Wysłane: poniedziałek, 24 lipca 2023 22:46 > Do: [email protected] > <[email protected]> > DW: Piotr Łobacz <[email protected]> > Temat: [OE-Core][PATCH v10][master-next 1/5] package_ipk.bbclass: add support > for ACLs and xattr > > Extend OPKGBUILDCMD variable, with additional parameters, depending > on target distro features, in order to support ACLs and xattr. > > With fix pushed to the opkg-devel: > https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fg%2Fopkg-devel%2Fc%2FdYNHrLjDwg8&data=05%7C01%7Cp.lobacz%40welotec.com%7C591c597fa0a04e4ecb3f08db8cf340eb%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638258748639032081%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IWhy2Cj%2BWUcAlyUY9doZltLivjF9%2FMwHsfgNP%2BGtoLI%3D&reserved=0<https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8> > opkg-build is able to create tar archives with ACLs and xattr. > > Signed-off-by: Piotr Łobacz <[email protected]> > --- > meta/classes-global/package_ipk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-global/package_ipk.bbclass > b/meta/classes-global/package_ipk.bbclass > index b4b7bc9ac2..a0f106e4ad 100644 > --- a/meta/classes-global/package_ipk.bbclass > +++ b/meta/classes-global/package_ipk.bbclass > @@ -15,7 +15,7 @@ IPKGCONF_SDK_TARGET = "${WORKDIR}/opkg-sdk-target.conf" > PKGWRITEDIRIPK = "${WORKDIR}/deploy-ipks" > > # Program to be used to build opkg packages > -OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}"' > +OPKGBUILDCMD ??= 'opkg-build -Z xz -a "${XZ_DEFAULTS}" > ${@bb.utils.contains('DISTRO_FEATURES', 'acl', '-A', '', d)} > ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', '-X', '', d)}' > > OPKG_ARGS += "--force_postinstall --prefer-arch-to-version" > OPKG_ARGS += "${@['', > '--no-install-recommends'][d.getVar("NO_RECOMMENDATIONS") == "1"]}" > -- > 2.34.1 > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com%2F&data=05%7C01%7Cp.lobacz%40welotec.com%7C591c597fa0a04e4ecb3f08db8cf340eb%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638258748639032081%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=N0DPKQWxIBeTfnxUMZGJrpJjFD%2B4fMje%2FDvn37%2FJGpE%3D&reserved=0<https://bootlin.com/>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#184829): https://lists.openembedded.org/g/openembedded-core/message/184829 Mute This Topic: https://lists.openembedded.org/mt/100347141/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
