On Tue, 2023-06-13 at 20:16 -0500, Randolph Sapp wrote: > On 6/12/23 14:46, Randolph Sapp via lists.openembedded.org wrote: > > On 6/12/23 05:05, Alexander Kanavin wrote: > > > On Mon, 12 Jun 2023 at 11:58, Peter Kjellerstedt > > > <[email protected]> wrote: > > > > Well that is of course an option, but then it may get messy if different > > > > people have different preferences and start changing the indentation > > > > back > > > > and forth... > > > > > > I suppose changing indentation needs to be justified by for example > > > achieving consistency in the same code block (as it does here, which > > > is fine), and it never should be mixed in with functional changes. > > > What I don't want is lots of empty code churn that doesn't actually > > > make things more readable than they already were, and is more or less > > > an exercise in pedantic neat freakery. > > > > > > Alex > > > > I frankly don't like the concept of mixed indentation in the same file, > > let alone the same code block. The only thing really driving me to > > change it here was the lack of git attributes to define the project > > standard, nvim is attempting to enforce the 4 space standard from python > > over the entirety of bitbake recipes (which I think is fairly sane), and > > the variance of standard in this code block. > > > > I have no preference. So long as there is a standard, I will bow to it. > > > > Randolph > > > > I noticed master didn't pick up any patches past this one. I take it you > want me to reformat this to the current tab shell block standard?
Yes please. I stopped there since at least at a quick glance it looked mostly tab indented and this changed it to space which breaks the code standard for oe-core. Whether we want to change that isn't something I have the time/energy to get into right now. If I take it, I'm opening the gates to many more such changes. There are views on both sides and people get upset about various aspects of it, me included. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#182739): https://lists.openembedded.org/g/openembedded-core/message/182739 Mute This Topic: https://lists.openembedded.org/mt/99441452/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
