I tend to agree with RP, this needs to be discussed with upstream first. We should avoid patches which are both conditional and non-upstreamable. If gawk upstream doesn't want their tests to be compatible with musl, then maybe neither should we.
Alex On Thu, 13 Apr 2023 at 15:17, Khem Raj <[email protected]> wrote: > > On Thu, Apr 13, 2023 at 3:14 AM Richard Purdie > <[email protected]> wrote: > > > > On Wed, 2023-04-12 at 22:54 -0700, Khem Raj wrote: > > > Signed-off-by: Khem Raj <[email protected]> > > > --- > > > ...0001-Provide-fixes-for-tests-on-musl.patch | 73 +++++++++++++++++++ > > > meta/recipes-extended/gawk/gawk_5.2.1.bb | 7 +- > > > 2 files changed, 77 insertions(+), 3 deletions(-) > > > create mode 100644 > > > meta/recipes-extended/gawk/gawk/0001-Provide-fixes-for-tests-on-musl.patch > > > > > > diff --git > > > a/meta/recipes-extended/gawk/gawk/0001-Provide-fixes-for-tests-on-musl.patch > > > > > > b/meta/recipes-extended/gawk/gawk/0001-Provide-fixes-for-tests-on-musl.patch > > > new file mode 100644 > > > index 0000000000..4ff2466c0e > > > --- /dev/null > > > +++ > > > b/meta/recipes-extended/gawk/gawk/0001-Provide-fixes-for-tests-on-musl.patch > > > @@ -0,0 +1,73 @@ > > > +From 95bcf4397b6f727208f3c627b7d00dacec406d02 Mon Sep 17 00:00:00 2001 > > > +From: Khem Raj <[email protected]> > > > +Date: Wed, 12 Apr 2023 21:57:18 -0700 > > > +Subject: [PATCH] Provide fixes for tests on musl > > > + > > > +Fixes rebt8b1 and regx8bit > > > +Disable clos1way6 [1] > > > + > > > +Disable commas and backsmalls1, they do not work > > > +with musl-locales somehow even though we do isntall > > > +en_US.UTF-8 on target > > > + > > > +[1] https://lists.gnu.org/archive/html/bug-gawk/2021-02/msg00005.html > > > + > > > +Upstream-Status: Inappropriate [musl-specific] > > > +Signed-off-by: Khem Raj <[email protected]> > > > +--- > > > + test/Maketests | 11 ++++------- > > > + > > > > Carrying a patch like this makes me a bit nervous as: > > > > a) it is only applied for musl so it makes recipe upgrade testing a > > nightmare > > > > b) there doesn't appear to be any path to upstream it, we'd just have > > to carry it indefinitely. > > > > c) the reasons for the failure don't seem to be understood. > > reasons are clear, these tests need full locale support which we do > not have with musl. > > > > > Is there something we can do to avoid having to carry this > > indefinitely? > > > > Out of interest did alpine do anything for this? > > they have patches. > > > > > Cheers, > > > > Richard > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179977): https://lists.openembedded.org/g/openembedded-core/message/179977 Mute This Topic: https://lists.openembedded.org/mt/98235523/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
