On Sat, Dec 17, 2022 at 3:17 AM Richard Purdie <[email protected]> wrote: > > On Thu, 2022-12-08 at 08:11 +0100, Ola x Nilsson wrote: > > Check for known symbols that should have been redirected to 64bit > > variants when -D_FILE_OFFSET_BITS=64 and -D_TIME_BITS=64 are set. > > > > Signed-off-by: Ola x Nilsson <[email protected]> > > --- > > meta/classes-global/insane.bbclass | 132 +++++++++++++++++++++++++++++ > > 1 file changed, 132 insertions(+) > > > > diff --git a/meta/classes-global/insane.bbclass > > b/meta/classes-global/insane.bbclass > > index df2c40c3c5..b0e99c4c3f 100644 > > --- a/meta/classes-global/insane.bbclass > > +++ b/meta/classes-global/insane.bbclass > > @@ -506,6 +506,138 @@ def package_qa_check_symlink_to_sysroot(path, name, > > d, elf, messages): > > trimmed = path.replace(os.path.join (d.getVar("PKGDEST"), > > name), "") > > oe.qa.add_message(messages, "symlink-to-sysroot", "Symlink > > %s in %s points to TMPDIR" % (trimmed, name)) > > > > +QAPATHTEST[32bit-time] = "check_32bit_symbols" > > +def check_32bit_symbols(path, packagename, d, elf, messages): > > + """ > > + Check that ELF files do not use any 32 bit time APIs from glibc. > > + """ > > + # TODO: We should have some DISTRO_FEATURE flag to check here > > + # if '-D_TIME_BITS=64' not in d.getVar('GLIBC_64BIT_TIME_FLAGS'): > > + # # No use checking if the feature is not enabled? > > + # return > > I did merge this patch with two fixes: > > a) It needed the class name in the subject line so we know which code > the patch changes at a glance > > b) I removed the above TODO since I don't think we should be adding a > distro feature for this, it can be handled by including a the include > file from the distro and setting WARN_QA and ERROR_QA as the distro > wishes.
Right, I think once it's sorted out and is working well, we should probably include it in poky distro conf and/or maybe even in defaultsetup.conf eventually. > > Cheers, > > Richard > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#174781): https://lists.openembedded.org/g/openembedded-core/message/174781 Mute This Topic: https://lists.openembedded.org/mt/95533492/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
