ACK from me - apart from enabling zstd by default.
On 9/13/22 07:37, Etienne Cordonnier via lists.openembedded.org wrote:
This allows the use of zstd for opkg packages by using OPKGBUILDCMD:
OPKGBUILDCMD = "opkg-build -Z zstd"
Signed-off-by: Alex Feinman <[email protected]>
Signed-off-by: Etienne Cordonnier <[email protected]>
---
meta/recipes-devtools/opkg/opkg_0.6.0.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/opkg/opkg_0.6.0.bb
b/meta/recipes-devtools/opkg/opkg_0.6.0.bb
index 7b351e8123..e38d9d6f3f 100644
--- a/meta/recipes-devtools/opkg/opkg_0.6.0.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.6.0.bb
@@ -30,7 +30,7 @@ inherit autotools pkgconfig ptest
target_localstatedir := "${localstatedir}"
OPKGLIBDIR ??= "${target_localstatedir}/lib"
-PACKAGECONFIG ??= "libsolv"
+PACKAGECONFIG ??= "libsolv zstd"
Building in zstd support by default is a little suspect to me.
Unless I'm mistaken, OE-core will only build xz-compressed IPKs by
default. So zstd support would be unnecessary for a distro integrator
who just uses upstream OE-core.
For distros which use zstd compression in their packages, I think it
would be more appropriate to overwrite the opkg PACKAGECONFIG in a
.bbappend.
Is there something I'm not considering here?
PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,\
gnupg gpgme libgpg-error,\
@@ -39,6 +39,7 @@ PACKAGECONFIG[gpg] = "--enable-gpg,--disable-gpg,\
PACKAGECONFIG[curl] = "--enable-curl,--disable-curl,curl"
PACKAGECONFIG[ssl-curl] = "--enable-ssl-curl,--disable-ssl-curl,curl openssl"
PACKAGECONFIG[sha256] = "--enable-sha256,--disable-sha256"
+PACKAGECONFIG[zstd] = "--enable-zstd,--disable-zstd,zstd"
PACKAGECONFIG[libsolv] = "--with-libsolv,--without-libsolv,libsolv"
EXTRA_OECONF:class-native = "--localstatedir=/${@os.path.relpath('${localstatedir}', '${STAGING_DIR_NATIVE}')} --sysconfdir=/${@os.path.relpath('${sysconfdir}', '${STAGING_DIR_NATIVE}')}"
--
Alex Stewart
Software Engineer - NI Real-Time OS
NI (National Instruments)
[email protected]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#170608):
https://lists.openembedded.org/g/openembedded-core/message/170608
Mute This Topic: https://lists.openembedded.org/mt/93654146/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
