On 8/4/22 15:58, Luca Ceresoli wrote:
Hi Joshua,
On Thu, 4 Aug 2022 09:58:31 -0500
"Joshua Watt" <[email protected]> wrote:
Add a comment so that users grepping for "github" or "gitlab" will find
this code (since the regex wont).
Signed-off-by: Joshua Watt <[email protected]>
---
meta/classes/insane.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 37e10ad850..c8b434bb54 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1335,6 +1335,7 @@ def unpack_check_src_uri(pn, d):
oe.qa.handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn,
d)
for url in d.getVar("SRC_URI").split():
+ # Search for github and gitlab URLs that pull unstable archives
(comment for future greppers)
if re.search(r"git(hu|la)b\.com/.+/.+/archive/.+", url):
I think the regexp is unnecessarily baroque and it could become just a
more readable (github|gitlab). And that would add only 4 chars! :-)
Ya that would be better. I assumed someone was trying to win regex golf ;)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168863):
https://lists.openembedded.org/g/openembedded-core/message/168863
Mute This Topic: https://lists.openembedded.org/mt/92814947/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
