On Mon, 11 Oct 2021 at 20:07, Peter Kjellerstedt <
[email protected]> wrote:
> > - mv ${D}${libdir}/ssl-1.1/certs \
> > - ${D}${libdir}/ssl-1.1/private \
> > - ${D}${libdir}/ssl-1.1/openssl.cnf \
> > + mv ${D}${libdir}/ssl-3/certs \
> > + ${D}${libdir}/ssl-3/private \
> > + ${D}${libdir}/ssl-3/openssl.cnf \
>
> Given that "${libdir}/ssl-3" is all over the recipe, wouldn't it make
> sense to turn it into a variable? Then it will at least only be one
> place to update the next time they change the version.
>
This changes very rarely and adjusting it was a very minor part of doing
the update, essentially a five second copy-replace. Fixing up everything
that broke due to previously long-deprecated APIs becoming hard errors, and
making the ptests pass again was the bulk of it, and I think we're not
quite done yet as I only checked and fixed oe-core and meta-oe. I'd
appreciate if you test other layers.
> There is a mix of tab and space indentation above (both in the original
> code and in the added lines).
>
> > +
>
> Unnecessary empty line.
>
Can you send a followup patch for these please?
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156872):
https://lists.openembedded.org/g/openembedded-core/message/156872
Mute This Topic: https://lists.openembedded.org/mt/86232768/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
