On Wed, Sep 29, 2021 at 1:34 AM Zoltán Böszörményi <[email protected]> wrote: > > I have observed two issues when upgrading to kernel versions > successively. > > One is that when installonly_limit is reached in dnf, only the > main kernel package was removed. Patch 1 fixes this by adding > extra RDEPENDS to the kernel subpackages on the main kernel package. > This circular dependency helps dnf to remove all subpackages. > > dnf.conf settings "installonlypkgs", "installonly_limit" and > others are documented at https://dnf.readthedocs.io/en/latest/conf_ref.html > > The second issue is that when the oldest kernel version is > removed by dnf, the /boot/bzImage symlink is also gone. > > Fix this by using update-alternatives instead of hardcoded ln -s > and rm -f. This is configurable via a new variable.
I'll comment on patch 2/2 directly, but I have a few things here as well. > > This is only an RFC at this point, because > 1) The first fix is only applied in the KERNEL_SPLIT_MODULES=0 case, > it may need its own knob or applied unconditionally. What is the outcome of the circular dependency you mention in patch 1/1 ? Does DNF warn, or something else ? What do the other package managers do when the circular dependency is detected ? But yes, I agree that we really don't want any more conditional code in the kernel packaging, since it isn't going to get tested. So whatever we do needs to work on all package managers and with or without kernel module splitting. > > 2) There's an extra issue I found while implementing the second patch: > instead of using KERNEL_VERSION, I had to resort to using PV > because the former is dynamically set via a python function > and it changes its value at some point between build phases. > AFAIK, there are kernel recipes out there using only the major > version with two numbers in PV instead of the full version triplet. > I can live with this as my kernel recipe uses the version triplet. > > 3) The new knob name for patch #2 is KERNEL_IMAGEDEST_USE_UPDATE_ALTERNATIVES. > It is admittedly too chatty, it can be renamed if someone suggests > a better name. I'll ponder this as well, but nothing is immediately coming to mind. Bruce > > Please advise how to fix and make it final so these fixes can be > accepted into openembedded-core. > > Best regards, > Zoltán Böszörményi > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#156469): https://lists.openembedded.org/g/openembedded-core/message/156469 Mute This Topic: https://lists.openembedded.org/mt/85942508/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
