On 17.05.21 12:35, Vinay Kumar wrote:
The qemu is booted with slirp mode. We are setting "self.use_slirp"
as "True" to avoid the error during qemuboot.
ERROR: Couldn't get ip from qemu command line and runqemu output! Here is the
qemu command line used:
We are setting "self.use_slirp=True" only when "slirp" is passed
"launch_cmd" through "runqemuparams".
Signed-off-by: Vinay Kumar <[email protected]>
---
meta/lib/oeqa/utils/qemurunner.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/lib/oeqa/utils/qemurunner.py
b/meta/lib/oeqa/utils/qemurunner.py
index 77ec939ad7..13abf6690d 100644
--- a/meta/lib/oeqa/utils/qemurunner.py
+++ b/meta/lib/oeqa/utils/qemurunner.py
@@ -184,6 +184,8 @@ class QemuRunner:
# and analyze descendents in order to determine it.
if os.path.exists(self.qemu_pidfile):
os.remove(self.qemu_pidfile)
+ if "slirp" in launch_cmd:
+ self.use_slirp=True
That doesn't look right to me - AFAIK slirp mode is activated from the
outside (by the class constructor) so it's the choice of the user to
enable slirp or not.
With this change a launchcmd containing
`image=this-is-a-non-slirp-image.tar.gz` would accidentally activate the
option.
I truly think this should be only set as part of the init() function and
not at this point
self.qemuparams = 'bootparams="{0}" qemuparams="-pidfile
{1}"'.format(bootparams, self.qemu_pidfile)
if qemuparams:
self.qemuparams = self.qemuparams[:-1] + " " + qemuparams + " " +
'\"'
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#151924):
https://lists.openembedded.org/g/openembedded-core/message/151924
Mute This Topic: https://lists.openembedded.org/mt/82883380/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
