On Wed, 24 Mar 2021 at 20:12, Steve Sakoman <[email protected]> wrote: > > On Wed, Mar 24, 2021 at 8:28 AM Khem Raj <[email protected]> wrote: > > > > > > > > On 3/24/21 8:09 AM, Steve Sakoman wrote: > > > On Sun, Mar 21, 2021 at 12:26 AM Anton Kachalov via > > > lists.openembedded.org <[email protected]> > > > wrote: > > >> > > >> From: "Anton D. Kachalov" <[email protected]> > > >> > > >> When running on the systems having read-only rootfs backed by overlayfs, > > >> removing the whole directory lead to create a special char device file > > >> on the upperdir to reflect directory's removal. Once it is required to > > >> upgrade the whole read-only image that might contain new postinsts > > >> scripts, > > >> it will be impossible to run such scripts with a "deletion mark" file > > >> on the overlayfs -- the whole directory will be marked as deleted > > >> regardless > > >> new files in it. > > > > > > Is this something that should be considered for backporting to > > > dunfell/gatesgarth? > > > > > > > yes seems so
I think so. I'm unsure which version does OpenBMC use: https://github.com/openbmc/openbmc/tree/master/poky They sync it from time to time from Poky upstream. > > I thought so too, since I need it :-) But I didn't want to grab it > just because I liked it! > > Steve > > > > > > >> Signed-off-by: Anton D. Kachalov <[email protected]> > > >> --- > > >> .../run-postinsts/run-postinsts/run-postinsts | 10 ++++------ > > >> 1 file changed, 4 insertions(+), 6 deletions(-) > > >> > > >> diff --git > > >> a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts > > >> b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts > > >> index f84a7e18c8..95dccb9cae 100755 > > >> --- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts > > >> +++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts > > >> @@ -72,12 +72,12 @@ exec_postinst_scriptlets() { > > >> else > > >> echo "ERROR: postinst $i failed." > > >> [ "$POSTINST_LOGGING" = "1" ] && eval echo > > >> "ERROR: postinst $i failed." $append_log > > >> - remove_pi_dir=0 > > >> + remove_rcsd_link=0 > > >> fi > > >> done > > >> } > > >> > > >> -remove_pi_dir=1 > > >> +remove_rcsd_link=1 > > >> if $pm_installed; then > > >> case $pm in > > >> "ipk") > > >> @@ -92,9 +92,7 @@ else > > >> exec_postinst_scriptlets > > >> fi > > >> > > >> -# since all postinstalls executed successfully, remove the postinstalls > > >> directory > > >> -# and the rcS.d link > > >> -if [ $remove_pi_dir = 1 ]; then > > >> - rm -rf $pi_dir > > >> +# since all postinstalls executed successfully, remove the rcS.d link > > >> +if [ $remove_rcsd_link = 1 ]; then > > >> remove_rcsd_link > > >> fi > > >> -- > > >> 2.31.0.rc2.261.g7f71774620-goog > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >>
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#150224): https://lists.openembedded.org/g/openembedded-core/message/150224 Mute This Topic: https://lists.openembedded.org/mt/81497013/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
