On Mon, 25 Jan 2021 at 16:25, Steve Sakoman <[email protected]> wrote: > > On Mon, Jan 25, 2021 at 5:42 AM Paul Barker <[email protected]> wrote: > > > > On Mon, 25 Jan 2021 at 14:51, Steve Sakoman <[email protected]> wrote: > > > > > > Issues with undetected file mode corruption in pseudo have been > > > identified. > > > > > > Fixes have been merged into master and gatesgarth over the past several > > > months and > > > things seem to have stabilized enough that we can consider backporting > > > these fixes > > > to dunfell. > > > > > > This is a somewhat more invasive change than normal. Specifically the > > > user will > > > be required to clean TMPDIR after this merge. It may also expose issues > > > with > > > other layers, though master and gategarth have probably helped to pave > > > the way for > > > this change. > > > > > > Personally I think that this fixes a serious enough issue that we should > > > consider > > > this series for dunfell. > > > > > > This second version includes the wic patches which have been the gating > > > item for > > > merging this series. > > > > > > Note also that there is an associated bitbake patch for stable/1.46: > > > > > > lib/bb/utils.py: Do not preserve TERM in the environment > > > > > > This is due to taking: > > > > > > bitbake.conf: Remove TERM from default BB_HASHBASE_WHITELIST > > > > > > which was needed to do clean cherry-picks of the pseudo changes. > > > > If this is just brought in to allow clean cherry-picks I think it > > would be better left out and instead do the small bit of rebasing > > required in the patches. We don't know what downstream users are doing > > with TERM so minimising unnecessary changes in the stable branch is > > preferable. > > OK, will do. > > > Everything else looks good to me at a glance. > > Thanks for reviewing. I'll wait for more feedback and send a v3. > This is one series we really want to get right!
Agreed. It's a difficult balance. I want stable branches to be as conservative as possible and not risk making breaking changes but this series fixes an important issue (risk of silently creating images with incorrect permissions). On balance it does make sense to backport these pretty invasive changes. Thanks, -- Paul Barker Konsulko Group
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#147219): https://lists.openembedded.org/g/openembedded-core/message/147219 Mute This Topic: https://lists.openembedded.org/mt/80104914/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
