On Thu, 2020-11-19 at 10:31 -0800, Stacy Gaikovaia wrote: > From: Stacy Gaikovaia <[email protected]> > > PTH_FUNC definition needs to be modified in order to > intercept posix thread functions in both libc and libpthread. > In order to handle this in helgrind, weak alias the pthread functions in > glibc. > This also prevents any need for a special case for musl, where > these definitions aren't duplicated. > > See https://bugs.kde.org/show_bug.cgi?id=428909 for additional > discussion. > > Signed-off-by: Paul Floyd <[email protected]> > Signed-off-by: Stacy Gaikovaia <[email protected]> > --- > ...01-helgrind-Intercept-libc-functions.patch | 45 +++++++++++++++++++ > .../valgrind/valgrind_3.16.1.bb | 1 + > 2 files changed, 46 insertions(+) > create mode 100644 > meta/recipes-devtools/valgrind/valgrind/0001-helgrind-Intercept-libc-functions.patch > > diff --git > a/meta/recipes-devtools/valgrind/valgrind/0001-helgrind-Intercept-libc-functions.patch > > b/meta/recipes-devtools/valgrind/valgrind/0001-helgrind-Intercept-libc-functions.patch > new file mode 100644 > index 0000000000..b3ab329bd8 > --- /dev/null > +++ > b/meta/recipes-devtools/valgrind/valgrind/0001-helgrind-Intercept-libc-functions.patch > @@ -0,0 +1,45 @@ > +From d02cafce8dd29df0309935beefbfbca1d8e29862 Mon Sep 17 00:00:00 2001 > +From: Paul Floyd <[email protected]> > +Date: Wed, 18 Nov 2020 12:49:20 -0400 > +Subject: [PATCH] helgrind: Intercept libc functions > + > +Signed-off-by: Paul Floyd <[email protected]> > + > +PTH_FUNC definition needs to be modified in order to > +intercept posix threa functions in both libc and > +libpthread. In order to handle this in helgrind, weak alias > +the pthread functions in glibc. > + > +Signed-off-by: Stacy Gaikovaia <[email protected]>
The patch in OE needs an Upstream-Status which would be Submitted in this case I guess. I've added as I queued the patch to save you resubmitting, thanks for the fix. Anuj: This should fix a ptest regression in gatesgarth that QA highlighted at release. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144846): https://lists.openembedded.org/g/openembedded-core/message/144846 Mute This Topic: https://lists.openembedded.org/mt/78371779/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
