I'd suggest using parenthesis to clarify the order here. 'a or b and c' isn't intuitively clear unless you know the or vs and operator precedence.
On Mon, Sep 28, 2020 at 6:38 AM Richard Purdie < [email protected]> wrote: > Most recipe-sysroot dependencies are handled by these prefuncs. "configure" > is special with a decidated task, prepare_recipe_sysroot which runs > beforehand. > > do_prepare_recipe_sysroot does not have to be run before/after > fetch/unpack/patch, they're independent tasks. If fetch/unpack/patch > have sysroot dependencies and those tasks rerun, stale items from the > sysroot could be uninstalled and since prepare_recipe_sysroot doesn't > re-run, they could be missing by the time configure runs. > > Fix this by adding the prefunc for do_configure which would ensure > the sysroot is in a good state. > > This issue can be reproduced by modifying do_unpack and watching > binutils-native and vulkan-headers failing due to missing makeinfo > or ninja. > > Signed-off-by: Richard Purdie <[email protected]> > --- > meta/classes/staging.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass > index de3a19815a3..7c9fb38607e 100644 > --- a/meta/classes/staging.bbclass > +++ b/meta/classes/staging.bbclass > @@ -614,7 +614,7 @@ python staging_taskhandler() { > bbtasks = e.tasklist > for task in bbtasks: > deps = d.getVarFlag(task, "depends") > - if deps and "populate_sysroot" in deps: > + if task == "do_configure" or deps and "populate_sysroot" in deps: > d.appendVarFlag(task, "prefuncs", " extend_recipe_sysroot") > } > staging_taskhandler[eventmask] = "bb.event.RecipeTaskPreProcess" > -- > 2.25.1 > > > > > -- Christopher Larson kergoth at gmail dot com Founder - BitBake, OpenEmbedded, OpenZaurus Senior Software Engineer, Mentor Graphics
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#142855): https://lists.openembedded.org/g/openembedded-core/message/142855 Mute This Topic: https://lists.openembedded.org/mt/77174124/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
