On Thu, Dec 1, 2011 at 9:46 AM, Koen Kooi <[email protected]> wrote: > Op 1 dec. 2011, om 17:38 heeft Christopher Larson het volgende geschreven: > >> This is needed by some kernels when CONFIG_KERNEL_LZO=y (specifically, given >> the current defconfig, this affects linux-omap4 2.6 in the meta-ti layer). >> >> Signed-off-by: Christopher Larson <[email protected]> >> --- >> meta/recipes-support/lzop/lzop/acinclude.m4 | 390 >> +++++++++++++++++++++++++++ >> meta/recipes-support/lzop/lzop_1.03.bb | 25 ++ >> 2 files changed, 415 insertions(+), 0 deletions(-) >> create mode 100644 meta/recipes-support/lzop/lzop/acinclude.m4 >> create mode 100644 meta/recipes-support/lzop/lzop_1.03.bb >> >> diff --git a/meta/recipes-support/lzop/lzop_1.03.bb >> b/meta/recipes-support/lzop/lzop_1.03.bb >> new file mode 100644 >> index 0000000..02a5590 >> --- /dev/null >> +++ b/meta/recipes-support/lzop/lzop_1.03.bb >> @@ -0,0 +1,25 @@ >> +inherit autotools > > That should go below SUMMARY/DESCRIPTION/DEPENDS
Personally, I think the fact that inherits are immediate is a problem, one we won't be able to fix in the long term unless we switch the recipes to a layout more like this one. But if maintaining the style standard is more important than that, I'll change it. >> +SUMMARY = "Real-time file compressor" >> +DESCRIPTION = "lzop is a compression utility which is designed to be a >> companion to gzip. \n\ >> +It is based on the LZO data compression library and its main advantages >> over \n\ >> +gzip are much higher compression and decompression speed at the cost of >> some \n\ >> +compression ratio. The lzop compression utility was designed with the goals >> \n\ >> +of reliability, speed, portability and with reasonable drop-in >> compatibility \n\ >> +to gzip." >> +DEPENDS += "lzo" > > I see the DEPENDS += pattern a lot, what are we prepending to? Especially > with the inherit going below this assignemnt. I see it as being a statement of intent. I want to add this dependency. I don't want to *replace* all dependencies. Regardless of what the previous value was, I think this is a better reflection of my intent. >> +PR = "r0" >> + >> +LICENSE = "GPLv2+" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=dfeaf3dc4beef4f5a7bdbc35b197f39e \ >> + >> file://src/lzop.c;beginline=5;endline=21;md5=6797bd3ed0a1a49327b7ebf9366ebd86" >> + >> +SRC_URI = "http://www.lzop.org/download/${BP}.tar.gz \ >> + file://acinclude.m4" >> + >> +do_configure () { >> + ln -sf ../acinclude.m4 >> + autotools_do_configure >> +} >> + >> +BBCLASSEXTEND += "native" > > nativesdk as well I guess. K. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
