Hi Scott,
Le 08/11/2011 00:47, Scott Garman a écrit :
Sorry to throw more churn into this, but can I ask you to submit a new pull
request for this?
In discussions with Richard today, he pointed out a few tricks that would
improve the patchset:
DEPENDS_append = "${USERADDDEPENDS}"
USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
USERADDDEPENDS_virtclass-nativesdk = ""
do_install[prefuncs] += "${SYSROOTFUNC}"
SYSROOTFUNC = "useradd_sysroot"
SYSROOTFUNC_virtclass-nativesdk = ""
that's clean it removes all the python code and ... that works !
I didn't want to take away credit for your patch, so if you'd be willing to
make these changes and respin your patch set, we'll take that.
well now you have written v2 of the patch so you also get the credits but the
most important thing beyond the credits is to have this bug fixed ;-)
The second thing is to avoid merge conflicts, can you rebase you patchset on
top of this branch:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgarman/useradd-rdepends-final
I just applied this patch and resent the 2 others on top of this one.
Thanks,
Eric
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
