On Tue, 2024-09-03 at 19:25 -0500, Ryan Eatmon wrote: > On 8/7/2024 11:30 AM, Richard Purdie wrote: > > The issue is that BB_DANGLINGAPPENDS_WARNONLY is a very poorly designed > > interface and is commonly abused. > > > > The challenge is that once it is set, by any layer, it applies > > everywhere. > > > > Some layers rely on this to get notification they need to update > > bbappend files and having the behaviour change from inclusion of an > > antisocial layer is not good. > > > > In addition, showing warnings as an accepted thing on the console > > devalues them and trains the user to ignore them. I want to steer us > > away from this mindset. > > > > There is more discussion about this in the following bug: > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=14870 > > > > We could extend the functionality and make it apply only to certain > > layers, or only to certain appends but then we've basically re-invented > > BBMASK. > > > > Given all the above, I'd therefore back the conclusion in the bug and > > propose we simply drop support for BB_DANGLINGAPPENDS_WARNONLY. > > As the maintainer of one of the offending layers that sets it. I'm fine > with this change. It makes sense. > > We discussed it and will move to using BBMASK to block the error until > we get a patch that addresses the no longer matching bbapends and then > unset BBMASK at that time. It's a little kludgy, but we can do it. > > The only feature request that goes along with this topic would be to > implement something like SKIP_RECIPE that prints a custom message to the > screen to tell people that the bbappends was not being processed. > > The main place in meta-arago where this occurs a lot is with the > gstreamer plugins where we carry some patches in the bbappend that is > locked to the specific version that the patches apply to. I have to > wait for someone on the graphics/multimedia team to get around to > updating the patches for the new versions of gstreamer. While we could > remove the patches and then re-add them back in later, for better git > tracking we like to rename the bbappends to the new version and then > make the needed changes. > > Having something like SKIP_RECIPE would allow me to mark the files as > skipped but print a message to the output reminding the graphics person > to unset the variable in the distro.conf. > > Not sure how well this works in python, but maybe something like: > > SKIP_BBAPPEND[gstreamer1.0-plugins-good_.*\.bbappend] = > "Remember to unset SKIP_BBAPPEND in the distro.conf file when > updating the gstreamer1.0-plugins-good bbappend file"
SKIP_RECIPE works since bitbake is parsing something, then realises it shouldn't and stops. We can log something in the cache, then if something references it, we can show the message. The bbappend is the opposite scenario, we need to show the message if nothing references it. This means always showing it to any user since we can't tell if the user is trying to access it or not. I'm not sure how to trigger showing such a message conditionally? :/ Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#2034): https://lists.openembedded.org/g/openembedded-architecture/message/2034 Mute This Topic: https://lists.openembedded.org/mt/107772184/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-architecture/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
