I think we need to get a balanced solution: -we can not ensure through validations that commits are ok. Development requires discipline (eg. test before you commit) -developers should usually use standard processes. But still shortcuts are valuable for experienced developers, they are responsible to use them properly (and they will be penalized if they use them wrong) -penalize lazy developers is fair and will lead to take it seriously. I guess it will not add too much effort to RM (hopefully it will happen very rarely)
Ismael -----Mensaje original----- De: Gorka Ion Damián [mailto:[email protected]] Enviado el: martes, 15 de septiembre de 2009 12:59 Para: Pablo Sarobe CC: Ismael Ciordia, Openbravo; [email protected]; 'Paolo Juvara' Asunto: Re: [Openbravo-development] [DB-Consistency-Check]-ERP-pi-pgsql-full > [Still Failing!] I agree with Pablo Sarobe. And I'd also remove the "-Dtr=no" option as using it might lead to unexpected changes in the AD_TextInterfaces table. Using this option AD_TextInterfaces is not updated, so when a developer compiles without that option can get differences that are not because of his developments. If the translation task is too slow we should try to make it faster, but never give the option to completely remove it. Regards Gorka Ion Pablo Sarobe wrote: > A validation that can be disabled by anyone is not a validation. The > rest is OK > > > Ismael Ciordia, Openbravo escribió: > >> All, >> >> let me put together suggestions from everybody: >> >> -export.database will have a validation. Originally this validation will >> only check that synchronize terminology will not change metadata (the most >> common mistake). We will include other validations if new common mistakes >> arise >> -this validation can be disabled (-Dvalidate=no, validate property can be >> persisted in openbravo.properties) >> -the incentive for developers to make it right is write access to pi: RM >> will remove write access privileges in pi repository for two weeks to a >> developer who: >> -commits a change that breaks nightly build and does not fix it within the >> next 48 hours >> -commits two changes that break nightly build within two consecutive >> weeks, no matter how fast it is fixed later >> -A developer without write access to pi will need to push to pi through a >> friend (who will be responsible if nigthly build is broken again) >> >> What do you think? >> >> Ismael >> >> -----Mensaje original----- >> De: Stefan Huehner [mailto:[email protected]] >> Enviado el: martes, 15 de septiembre de 2009 10:52 >> Para: Pablo Sarobe >> CC: [email protected]; Paolo Juvara >> Asunto: Re: [Openbravo-development] >> [DB-Consistency-Check]-ERP-pi-pgsql-full > [Still Failing!] >> >> >> Pablo Sarobe wrote: >> >> >>> I agree with Isma's approach and for sure I wouldn't allow to disable >>> the validation. The validation should be a must >>> >>> >> Hi, >> >> we already have some validation in place on export and disabling it is >> already possible (and useful sometimes). You don't want to block a >> commit/MP just because the validation code itself has a bug... >> >> The case of people disabling it and then forgetting some mandatory tasks >> (like synchronize terminology) can be easily caught in process... >> >> One extra note: Synchronize terminology is only one step of several >> which might be necessary (depending on what you develop)... change in >> whitespace in src-db or forgetting to compile.complete once with core in >> development (to update ad_textinterfaces...) are also possible problems >> (if they are forgotten) and won't be solved by this.. >> >> I am still in favor of a educate/talk to people or give an incentive to >> make it right, like: 1 Euro into a box for each violation and we all get >> some tortillas if we have enough.. >> >> Cheers, >> Stefan >> >> ------------------------------------------------------------------------- --- >> -- >> Come build with us! The BlackBerry® Developer Conference in SF, CA >> is the only developer event you need to attend this year. Jumpstart your >> developing skills, take BlackBerry mobile applications to market and stay >> ahead of the curve. Join us from November 9-12, 2009. Register now! >> http://p.sf.net/sfu/devconf >> _______________________________________________ >> Openbravo-development mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/openbravo-development >> >> >> >> > > > -------------------------------------------------------------------------- ---- > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Openbravo-development mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openbravo-development > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Openbravo-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-development
