Isma, Today it has happened again. So I've just added a hook script that will abort the push transaction if the author name is not properly configured.
Regards, Juan Pablo On 11:05 Fri 26 Jun , Ismael Ciordia, Openbravo wrote: > Juapa, > > not sure if it is needed to do the validation you propose. In my opinion it > is enough to write this policy in the wiki (done, I know :) and then keep an > eye on it. I guess it will not happen very frequently... > > But you decide if it is worth ... > > Ismael > > -----Mensaje original----- > De: Juan Pablo Aroztegi [mailto:[email protected]] > Enviado el: viernes, 26 de junio de 2009 10:50 > Para: [email protected] > Asunto: Re: > [Openbravo-development][DB-Consistency-Check]-ERP-pi-pgsql-full > > [Failure!] > > > Hi Isma, > > Th real name is configured by each of us in a mercurial config file. For > example, in my case: > > $ cat .hgrc > [ui] > username = Juan Pablo Aroztegi <juanpablo.arozt...@o_penbravo.com> > > This is used for the commits (local). Apart from this, there is a > username/password to do pushes to code.openbravo.com. > > Being Mercurial distributed, the real name in the commits can be > whatever name. That is, I can pull from any user around the world and > push the changes. > > However, in the documentation [1] we tell people to configure > it in the way "Real Name <[email protected]>". This particular user (a > configured it wrong and pushed the result. He has already corrected it. > > What can we do about this? We'll add a pre-push check that verifies that > at least the committers user name is in the form: > "Real Name <[email protected]>". > > > Regards, > > Juan Pablo > > > [1] > http://wiki.openbravo.com/wiki/Mercurial_Manual_for_Openbravo_Developers#Con > figuration > > > On 10:44 Fri 26 Jun , Ismael Ciordia, Openbravo wrote: > > Who is openbravo user? All developers in code.openbravo.com should be > > properly identified. > > > > Ismael > > > > -----Mensaje original----- > > De: Juan Pablo Aroztegi [mailto:[email protected]] > > Enviado el: viernes, 26 de junio de 2009 0:14 > > Para: [email protected] > > Asunto: Re: > > [Openbravo-development][DB-Consistency-Check]-ERP-pi-pgsql-full > > > [Failure!] > > > > > > Changeset 874f858909d8 [1] introduced the inconsistency because it > > included ^M as end of lines. Fix pushed to remove this characters. > > > > It would be worth it to know how these characters were introduced. > > > > > > > > Juan Pablo > > > > [1] https://code.openbravo.com/erp/devel/pi/rev/874f858909d8 > > > > On 21:29 Thu 25 Jun , [email protected] wrote: > > > erp_devel_pi-pgsql-db-full-consistency-test - Build # 70 - Failure: > > > > > > Check console output at > > > http://builds.openbravo.com/job/erp_devel_pi-pgsql-db-full-consistency-test/ > > 70/ to view the results. > > > > > > > -------------------------------------------------------------------------- > > ---- > > > _______________________________________________ > > > Openbravo-development mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/openbravo-development > > > > > > -------------------------------------------------------------------------- > -- > > -- > > _______________________________________________ > > Openbravo-development mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/openbravo-development > > > > > ---------------------------------------------------------------------------- > -- > _______________________________________________ > Openbravo-development mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openbravo-development > ------------------------------------------------------------------------------ _______________________________________________ Openbravo-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-development
