simgunz added inline comments.
INLINE COMMENTS
> davidhurka wrote in pageview.h:75
> In the meantime I learned more about this.
>
> The Color Mode menu will stay here in PageView::setupViewerActions(), because
> it is needed only in viewer modes, and is page view related.
>
> m_embedMode is not needed, that’s handled by Part.
>
> But I still don’t like the parameter part, any comments?
You can add an action in `Part::setupActions` similar to
`options_configure_annotations`. Then in you can access it with something
similar to
QAction * aConfigColors = actionCollection()->action(
QStringLiteral("options_configure_colors") );
d->aColorModeMenu->addAction( aConfigColors );
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D21195
To: davidhurka, #okular, #vdg
Cc: simgunz, GB_2, aacid, ngraham, okular-devel, johnzh, andisa,
siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
