sander added a comment.

  > I'd advocate to implement drawing the lines by code, i.e. 
QPainter::drawLine and friends. Then reuse the same code to draw icons.
  
  Agreed, but that is too much for a single patch.
  
  Rajeesh, nice patch!  Can you get rid of the unicode symbols in the source 
code using one of the ways Tobias proposed?  After that I would say that patch 
is good and can be applied.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

To: knambiar, #okular, #vdg
Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, 
tfella, darcyshen, aacid

Reply via email to