ngraham edited reviewers, added: VDG; removed: ngraham. ngraham added a comment.
Interesting feature. Can confirm that it works for me; tested with a bunch of PDFs and ePubs with selectable text. No effect with documents that don't have selectable text. No crashes. Seems sane enough to me. However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there? In the future for user interface or user-facing changes, please add #VDG <https://phabricator.kde.org/tag/vdg/> instead of me directly (that way other UI and UX designers can see it too) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: okular-devel, tfella, ngraham, darcyshen, aacid
