tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision.
REVISION SUMMARY This is mainly preparation for D15204 <https://phabricator.kde.org/D15204> (typewriter), where storing RGB won't be sufficient any longer. Typewriter will need transparent background (alpha=0x00), which can only be expressed as ARGB string. Current code handles name format identical for all annotations. It doesn't hurt to store all annotations in ARGB format, so instead of introducing special handling for typewriter, let's store all annotation color attributes as ARGB string. TEST PLAN - when [Reviews] section in okularpartrc is initially generated, all annotation color attributes are in #AARRGGBB format - saving into archive stores color with alpha channel (#AARRGGBB), for all kind of annotations REPOSITORY R223 Okular BRANCH annotation_rgba REVISION DETAIL https://phabricator.kde.org/D15279 AFFECTED FILES conf/editannottooldialog.cpp core/annotations.cpp ui/data/tools.xml To: tobiasdeiminger Cc: okular-devel, ngraham, aacid
