[
https://issues.apache.org/jira/browse/ODFTOOLKIT-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146959#comment-16146959
]
Svante Schubert commented on ODFTOOLKIT-464:
--------------------------------------------
Hello Olivier,
The dependencies viewed in the maven dependencies tree are at compile-time (as
labeled by the suffix of each entry), not necessary run-time dependencies.
For instance, there are no run-time dependencies on com.sun.tools JAR. These
are only used for the taglets to create HTML references to the ODF
specification within our JavaDoc.
You can double check by taking a looking into the JAR with all dependencies, it
is
<ODF_TOOLKIT_ROOT>simple/target/simple-odf-0.9.0-incubating-SNAPSHOT-jar-with-dependencies.jar
Regarding slf4j, take a look at https://www.slf4j.org/
It is the Simple Logging Facade for Java (SLF4J) which serves as a simple
facade or abstraction for various logging frameworks (e.g. java.util.logging,
logback, log4j) allowing the end user to plug in the desired logging framework
at deployment time.
No pain from my side to remove this.
I see no evident problem for me to be solved, there are others more important
to me that require my attention, but if you (or others) have suggestions to
improve the situation patches are welcome.
Best,
Svante
> Pom does not follow best practices: missing optional keyword
> ------------------------------------------------------------
>
> Key: ODFTOOLKIT-464
> URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-464
> Project: ODF Toolkit
> Issue Type: Bug
> Components: simple api
> Reporter: Olivier Cailloux
> Priority: Minor
>
> When depending on Apache ODFToolkit simple-odf in my application
> (org.apache.odftoolkit:simple-odf:0.8.2-incubating), I observe that
> com.sun:tools is transitively imposed on my project as a dependency (coming
> from taglets, see its
> [POM|https://repo1.maven.org/maven2/org/apache/odftoolkit/taglets/0.8.11-incubating/taglets-0.8.11-incubating.pom]).
> Similarly, org.slf4j:slf4j-log4j12 is passed to my project as a dependency.
> I suspect these dependencies are actually not required for projects depending
> on simple-odf.
> It is possible and simple to ease the life of users of simple-odf by adding
> <optional> in the relevant pom files. This would respect Maven best
> practices. (See for example
> [SO|https://stackoverflow.com/questions/32231814/how-can-i-remove-logback-from-a-librarys-dependency-while-keeping-slf4j].)
> Workaround: add exclusion rules for these artifacts (see this example
> [POM|https://github.com/oliviercailloux/Test-ODFToolkit-ODS/blob/master/pom.xml]).
> (I tried to discuss it
> [here|https://lists.apache.org/thread.html/6fa4257e67ede90bac58f5518e1be41e7561a451149cbc9eecdbbf1e@%3Codf-users.incubator.apache.org%3E]
> but received no answer.)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
