On 06.05.2013 23:12, Rob Weir wrote:
> On Fri, May 3, 2013 at 2:05 AM, Florian Hopf
> <[email protected]> wrote:
>> Thanks for your feedback, this needs to be fixed.
>>
>
> I added the DISCLAIMER.txt file. The packaging logic already sucks
> in /*.txt into the tar.gz/zip/bz2 archives, so all we needed to do was
> check in the file.
Rob, thanks for helping.
>
> For the src.xml missing the license header, it looks like it was
> explicitly excluded from the ODF Validator's Rat scan plugin:
>
> <exclude>src/main/assembly/src.xml</exclude>
>
> The exclusion is not necessary. We can add it as an XML comment like
> we do with the root pom.xml. I'd do it myself, but SVN seens
> unavailable right now.
I added the header, removed the exclusion and it builds OK with the
pedantic profile.
Is there anything we need to do to the files in
src/main/resources/schema in the validator module? Those still contain
an Oracle license, I don't know if we can remove it.
>
> Fortunately we do a Rat scan with every check-in, as part of our
> continuous integration, so cases like this should be rare.
>
> Regards,
>
> -Rob
>
>
>> For reference:
>> http://www.apache.org/legal/src-headers.html
>> http://incubator.apache.org/guides/branding.html
>>
>>
>> On 02.05.2013 16:34, sebb wrote:
>>>
>>> There is no DISCLAIMER that I could see in the SVN tag nor in the
archive.
>>> This is required of all Incubator projects.
>>>
>>> Some files don't have AL headers, for example:
>>>
>>> validator/src/main/assembly/src.xml
>>>
>>>
>>>
>>> On 2 May 2013 12:55, Rob Weir <[email protected]> wrote:
>>>
>>>> On Thu, May 2, 2013 at 4:41 AM, sebb <[email protected]> wrote:
>>>>>
>>>>> On 2 May 2013 07:04, Florian Hopf <[email protected]>
wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> The ODF Toolkit 0.6 is ready for release.
>>>>>>
>>>>>> We had a successful vote in the PPMC. The PPMC vote result is here:
>>>>>> http://markmail.org/message/**fqikz72pys4qr7pa<
>>>>
>>>> http://markmail.org/message/fqikz72pys4qr7pa>
>>>>>>
>>>>>>
>>>>>> We need three more IPMC votes to pass.
>>>>>>
>>>>>> Please vote on releasing the following candidate as Apache ODF
Toolkit
>>>>>> (incubating) version 0.6.
>>>>>>
>>>>>>
>>>>
>>>>
http://people.apache.org/~**fhopf/odftoolkit-release/0.6-**incubating-rc4/
>>>>
<http://people.apache.org/~fhopf/odftoolkit-release/0.6-incubating-rc4/>
>>>>>>
>>>>>>
>>>>>> The SHA1 checksum of the archive zip source is
>>>>>> 000e25c3b6baf4099e067c8d93cea3**636a24ddfd
>>>>>>
>>>>>> The SHA1 checksum of the archive zip binary is
>>>>>> f505f7c607098cdd77797417485584**49918b0b45
>>>>>>
>>>>>> The changes can be found at here:
>>>>>>
>>>>>> https://svn.apache.org/repos/**asf/incubator/odf/tags/0.6-**
>>>>>> incubating-rc4/CHANGES.txt<
>>>>
>>>>
>>>>
https://svn.apache.org/repos/asf/incubator/odf/tags/0.6-incubating-rc4/CHANGES.txt
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>> Where is the SVN/GIT tag?
>>>>>
>>>>
>>>>
https://svn.apache.org/repos/asf/incubator/odf/tags/0.6-incubating-rc4/
>>>>
>>>> -Rob
>>>>
>>>>> The source code repo is needed to check provenance.
>>>>>
>>>>>
>>>>>
>>>>>> The vote is open for 72 hours, or until we get the needed number of
>>>>
>>>> votes
>>>>>>
>>>>>> (3 +1).
>>>>>>
>>>>>> [ ] +1 Release this package as Apache ODF Toolkit 0.5-incubating
>>>>>> [ ] -1 Do not release this package because...
>>>>>>
>>>>>> To learn more about Apache ODF Toolkit, please visit
>>>>>> http://incubator.apache.org/**odftoolkit/<
>>>>
>>>> http://incubator.apache.org/odftoolkit/>
>>>>>>
>>>>>> .
>>>>>>
>>>>>> Regards
>>>>>> Florian
>>>>>>
>>>>>>
>>>>
------------------------------**------------------------------**---------
>>>>>>
>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.**apache.org<
>>>>
>>>> [email protected]>
>>>>>>
>>>>>> For additional commands, e-mail:
[email protected].**org<
>>>>
>>>> [email protected]>
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [email protected]
>>>> For additional commands, e-mail: [email protected]
>>>>
>>>>
>>>
>>
>>
>> --
>> Florian Hopf
>> Freelance Software Developer
>>
>> http://blog.florian-hopf.de
>
--
Florian Hopf
Freelance Software Developer
http://blog.florian-hopf.de
