[jira] [Comment Edited] (OAK-11946) Gradually replace Guava Cache Interfaces by Oak-specific internal APIs

Fri, 20 Mar 2026 06:48:13 -0700 


    [ 
https://issues.apache.org/jira/browse/OAK-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067062#comment-18067062
 ] 

Julian Reschke edited comment on OAK-11946 at 3/20/26 1:47 PM:
---------------------------------------------------------------

Looking at baseline output (relative to 1.92.0):

{noformat}
$ ack guava */target/basel*.xml
oak-commons/target/baseline.xml
55:      <uses>org.apache.jackrabbit.guava.common.util.concurrent</uses>
62:      <method 
name="toCompletableFuture(org.apache.jackrabbit.guava.common.util.concurrent.ListenableFuture)"
 delta="removed">

oak-core-spi/target/baseline.xml
14:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
19:      <implements 
name="org.apache.jackrabbit.guava.common.cache.LoadingCache" delta="removed"/>
28:        <return 
name="org.apache.jackrabbit.guava.common.collect.ImmutableMap" delta="removed"/>
35:        <return 
name="org.apache.jackrabbit.guava.common.collect.ImmutableMap" delta="removed"/>
49:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
56:      <method 
name="build(org.apache.jackrabbit.guava.common.cache.CacheLoader)" 
delta="removed">
62:      <method 
name="weigher(org.apache.jackrabbit.guava.common.cache.Weigher)" 
delta="removed">
76:      <method 
name="&lt;init&gt;(org.apache.jackrabbit.guava.common.cache.Cache,java.lang.String,org.apache.jackrabbit.guava.common.cache.Weigher,long)"
 delta="removed">
87:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
92:      <implements name="org.apache.jackrabbit.guava.common.cache.Weigher" 
delta="removed"/>
105:      <method 
name="evicted(java.lang.Object,java.lang.Object,org.apache.jackrabbit.guava.common.cache.RemovalCause)"
 delta="removed">

oak-segment-tar/target/baseline.xml
23:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>

oak-shaded-guava/target/baseline.xml
1:<baseline version="1.0.0" vendor="The Apache Software Foundation" 
vendorURL="http://www.apache.org/"; generator="Apache Felix Maven Bundle Plugin" 
generatorURL="http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html";
 analyzer="Bnd" analyzerURL="http://www.aqute.biz/Bnd/Bnd"; 
generatedOn="2026-03-20T14:33Z" bundleName="oak-shaded-guava" 
currentVersion="1.93-SNAPSHOT" previousVersion="1.92.0">
2:  <package name="org.apache.jackrabbit.guava.common.base" delta="unchanged">
11:  <package name="org.apache.jackrabbit.guava.common.cache" delta="unchanged">
18:      
<uses>org.apache.jackrabbit.guava.common.base,org.apache.jackrabbit.guava.common.collect,org.apache.jackrabbit.guava.common.util.concurrent</uses>
21:  <package name="org.apache.jackrabbit.guava.common.collect" 
delta="unchanged">
28:      <uses>org.apache.jackrabbit.guava.common.base</uses>
31:  <package name="org.apache.jackrabbit.guava.common.graph" delta="removed">
38:  <package name="org.apache.jackrabbit.guava.common.hash" delta="removed">
45:  <package name="org.apache.jackrabbit.guava.common.util.concurrent" 
delta="unchanged">
52:      
<uses>org.apache.jackrabbit.guava.common.base,org.apache.jackrabbit.guava.common.collect,org.apache.jackrabbit.guava.common.util.concurrent.internal,org.apache.jackrabbit.guava.common.primitives</uses>
{noformat}

Why aren't we gettting baseline warnings/errors?


was (Author: reschke):
Looking at baseline output:

{noformat}
$ ack guava */target/basel*.xml
oak-commons/target/baseline.xml
55:      <uses>org.apache.jackrabbit.guava.common.util.concurrent</uses>
62:      <method 
name="toCompletableFuture(org.apache.jackrabbit.guava.common.util.concurrent.ListenableFuture)"
 delta="removed">

oak-core-spi/target/baseline.xml
14:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
19:      <implements 
name="org.apache.jackrabbit.guava.common.cache.LoadingCache" delta="removed"/>
28:        <return 
name="org.apache.jackrabbit.guava.common.collect.ImmutableMap" delta="removed"/>
35:        <return 
name="org.apache.jackrabbit.guava.common.collect.ImmutableMap" delta="removed"/>
49:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
56:      <method 
name="build(org.apache.jackrabbit.guava.common.cache.CacheLoader)" 
delta="removed">
62:      <method 
name="weigher(org.apache.jackrabbit.guava.common.cache.Weigher)" 
delta="removed">
76:      <method 
name="&lt;init&gt;(org.apache.jackrabbit.guava.common.cache.Cache,java.lang.String,org.apache.jackrabbit.guava.common.cache.Weigher,long)"
 delta="removed">
87:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>
92:      <implements name="org.apache.jackrabbit.guava.common.cache.Weigher" 
delta="removed"/>
105:      <method 
name="evicted(java.lang.Object,java.lang.Object,org.apache.jackrabbit.guava.common.cache.RemovalCause)"
 delta="removed">

oak-segment-tar/target/baseline.xml
23:        <return name="org.apache.jackrabbit.guava.common.cache.CacheStats" 
delta="removed"/>

oak-shaded-guava/target/baseline.xml
1:<baseline version="1.0.0" vendor="The Apache Software Foundation" 
vendorURL="http://www.apache.org/"; generator="Apache Felix Maven Bundle Plugin" 
generatorURL="http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html";
 analyzer="Bnd" analyzerURL="http://www.aqute.biz/Bnd/Bnd"; 
generatedOn="2026-03-20T14:33Z" bundleName="oak-shaded-guava" 
currentVersion="1.93-SNAPSHOT" previousVersion="1.92.0">
2:  <package name="org.apache.jackrabbit.guava.common.base" delta="unchanged">
11:  <package name="org.apache.jackrabbit.guava.common.cache" delta="unchanged">
18:      
<uses>org.apache.jackrabbit.guava.common.base,org.apache.jackrabbit.guava.common.collect,org.apache.jackrabbit.guava.common.util.concurrent</uses>
21:  <package name="org.apache.jackrabbit.guava.common.collect" 
delta="unchanged">
28:      <uses>org.apache.jackrabbit.guava.common.base</uses>
31:  <package name="org.apache.jackrabbit.guava.common.graph" delta="removed">
38:  <package name="org.apache.jackrabbit.guava.common.hash" delta="removed">
45:  <package name="org.apache.jackrabbit.guava.common.util.concurrent" 
delta="unchanged">
52:      
<uses>org.apache.jackrabbit.guava.common.base,org.apache.jackrabbit.guava.common.collect,org.apache.jackrabbit.guava.common.util.concurrent.internal,org.apache.jackrabbit.guava.common.primitives</uses>
{noformat}

Why aren't we gettting baseline warnings/errors?

> Gradually replace Guava Cache Interfaces by Oak-specific internal APIs
> ----------------------------------------------------------------------
>
>                 Key: OAK-11946
>                 URL: https://issues.apache.org/jira/browse/OAK-11946
>             Project: Jackrabbit Oak
>          Issue Type: Task
>            Reporter: Julian Reschke
>            Assignee: Rishabh Daim
>            Priority: Major
>
> These would be identical to the Guava interfaces - modulo package names - 
> potentially stripped of unused stuff.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to