[ 
https://issues.apache.org/jira/browse/OAK-12128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064369#comment-18064369
 ] 

Julian Reschke commented on OAK-12128:
--------------------------------------

Thanks [~corderob] for pointing out that the new method will actually swallow 
exceptions thrown by the document store method; this is now fixed.

Left to discuss: additional error logging? That would also adress the case 
above, because we'd see the lease end warning as well.

> Fail earlier (and add more diags) when detecting late writes
> ------------------------------------------------------------
>
>                 Key: OAK-12128
>                 URL: https://issues.apache.org/jira/browse/OAK-12128
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: documentmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>         Attachments: leasecheck.diff
>
>
> While discussing late write with [~stefanegli] we realized that late writes 
> (or at least some of them) can actually be detected in 
> LeaseCheckDocumentStoreWrapper - if a write call starts *before* lease end  
> and completes *after* lease end, it is (likely?) a late write and we can 
> either make it fail, or at least log it.
> Q1: does this make sense at all?
> Q2: exception? log? both?
> Q3: write operations or all?
> Q4: add more details to exception? (like method invoked - however stack trace 
> will tell us anyway)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to