Citeren Michal Soltys <[email protected]>:
Summary:
- new driver options: ignorelb, minbatt, mintime, wugrace, advorder
- expanded: sdtype
- few more types in compatibility table
- minor fixes and adjustments
First of all, thanks for the effort of working on this driver. The
lack of an active developer for APC units has worried us for some time
already, given the popularity of the brand.
Most of the patches are good to go, with the exception of the
'minbatt' and 'mintime'. These are generic functions that I would
prefer to see included in the main driver core, rather than in each
driver individually.
We already support adding missing constants
(default.battery.charge.low) or overriding wrong ones
(override.battery.charge.low) in 'ups.conf'. The only thing that is
missing now in the driver core are the checks
battery.charge < battery.charge.low
battery.runtime < battery.runtime.low
Adding the above is trivial and would then be usable for all drivers.
Therefor I don't think it is a good idea to do this here.
Best regards, Arjen
--
Please keep list traffic on the list (off-list replies will be rejected)
_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
