On Mon, Jun 22, 2015 at 12:48 AM, Honi Sanders <h...@brandeis.edu> wrote:
> OK. So I am in the midst of a pull request adding a “maxlag” mode to > correlate ( > https://github.com/numpy/numpy/compare/master...bringingheavendown:maxlag). > Am I to understand that I no longer need to preserve the old_behavior > functionality? > Indeed. It was scheduled for ripping out for a long time, and Chuck finally got that done. > Is it possible that we could address my pull request and then remove the > old_behavior functionality because now my pull request is unmergeable. > We can't undo the merge that made your PR need a rebase, but I'm happy to help you with the rebase and getting that into your branch if needed. Ralf > Honi > > On Jun 20, 2015, at 5:32 PM, Nathaniel Smith <n...@pobox.com> wrote: > > On Jun 20, 2015 1:43 PM, "Charles R Harris" <charlesr.har...@gmail.com> > wrote: > > > > Hi All, > > > > There are three long ago deprecations that I am not sure how to handle. > > > > keywords skiprows and missing in genfromtxt, deprecated in 1.5. > > keyword old_behavior (default False) in correlate. added in 1.5 at > least, but default value changed later. > > > > The documentation says they will be removed in numpy 2.0, but we might > want to try ealier. The case of the correlation function is trickier, as we > probabaly need to provide a function with the old behavior before removing > the keyword. > > Wouldn't this function just be > correlate(a, conj(b)) > ? Surely just writing that is easier and clearer than any function call we > could provide. > > > I've left these cases as is, but the more old stuff hanging about the > greater our technical debt. > > I guess we could try dropping them from the first release candidate and at > least get some data on whether anyone notices. > > 1.5 was a lonnnng time ago. > > -n > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion > > > > _______________________________________________ > NumPy-Discussion mailing list > NumPy-Discussion@scipy.org > http://mail.scipy.org/mailman/listinfo/numpy-discussion > >
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
