I've specifically not tuned it, primarily because the get the best tuning you need to know the likelihood of finding a match. One option would be to allow users to specify a "probability" parameter which would chunk the array into size*probability chunks - an additional parameter could then be exposed to limit the maximum chunk size to give the user control of the maximum memory overhead that the routine could use.
I'll submit a PR and we can discuss inline. Thanks for the response Nathaniel. On 27 March 2013 12:19, Nathaniel Smith <[email protected]> wrote: > On Tue, Mar 26, 2013 at 9:20 AM, Phil Elson <[email protected]> wrote: > > Bump. > > > > I'd be interested to know if this is a desirable feature for numpy? > > (specifically the 1D "find" functionality rather than the "any"/"all" > also > > discussed) > > If so, I'd be more than happy to submit a PR, but I don't want to put in > the > > effort if the principle isn't desirable in the core of numpy. > > I don't think anyone has a strong opinion either way :-). It seems > like a fairly general interface that people might find useful, so I > don't see an immediate objection to including it in principle. It > would help to see the actual numbers from a tuned version though to > know how much benefit there is to get... > > -n > _______________________________________________ > NumPy-Discussion mailing list > [email protected] > http://mail.scipy.org/mailman/listinfo/numpy-discussion >
_______________________________________________ NumPy-Discussion mailing list [email protected] http://mail.scipy.org/mailman/listinfo/numpy-discussion
