On 9/26/25 6:05 AM, Danilo Krummrich wrote: > Meanwhile nova-core depends on CONFIG_64BIT and a raw DmaAddress is > always a u64, hence remove the now actually useless conversion. >
Because I'm already here and have at least mild OCD, I'll suggest saying it like this: "Because nova-core depends on CONFIG_64BIT and a raw DmaAddress is always a u64, we can remove the now actually useless conversion." > Signed-off-by: Danilo Krummrich <[email protected]> > --- > drivers/gpu/nova-core/firmware/gsp.rs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Either way, it's clearly correct, so: Reviewed-by: John Hubbard <[email protected]> thanks, John Hubbard > > diff --git a/drivers/gpu/nova-core/firmware/gsp.rs > b/drivers/gpu/nova-core/firmware/gsp.rs > index 9b70095434c6..ca785860e1c8 100644 > --- a/drivers/gpu/nova-core/firmware/gsp.rs > +++ b/drivers/gpu/nova-core/firmware/gsp.rs > @@ -202,8 +202,7 @@ pub(crate) fn new<'a, 'b>( > let mut level0_data = kvec![0u8; GSP_PAGE_SIZE]?; > > // Fill level 1 page entry. > - #[allow(clippy::useless_conversion)] > - let level1_entry = > u64::from(level1.iter().next().unwrap().dma_address()); > + let level1_entry = > level1.iter().next().unwrap().dma_address(); > let dst = &mut level0_data[..size_of_val(&level1_entry)]; > dst.copy_from_slice(&level1_entry.to_le_bytes()); > > > base-commit: 299eb32863e584cfff7c6b667c3e92ae7d4d2bf9
