On Mon Sep 8, 2025 at 9:18 PM JST, Miguel Ojeda wrote: > On Thu, Aug 21, 2025 at 2:42 PM Alexandre Courbot <[email protected]> wrote: >> >> +/// TODO: Temporary substitute for the [`Alignment`] nightly type from the >> standard library, and to >> +/// be eventually replaced by it. > > Should this be a comment, i.e. `//`, rather than part of the docs? (It > is fine intermixing if needed, or putting them at the end of the docs > too).
It's probably better as a regular comment indeed. > >> + /// Validates that `align` is a power of two at runtime, and returns an >> + /// [`Alignment`] of the same value. >> + /// >> + /// [`None`] is returned if `align` is not a power of two. > > "Returns [`None`] if ..." is probably simpler. > > (Sending these two nits since you will send a new version with the > const generic.) Thanks, I'll apply them!
