On 8/28/25 12:08 AM, Alexandre Courbot wrote: ... >>>> This worries me a bit, because we never checked that these bounds >>>> are reasonable: within the range of the firmware, and not overflowing >>>> (.checked_add() for example), that sort of thing. >>>> >>>> Thoughts? >>> >>> `get` returns `None` if the requested slice is out of bounds, so there >>> should be no risk of panicking here. >> >> I was wondering about the bounds themselves, though. Couldn't they >> be wrong? (Do we care?) > > Not sure what you mean by wrong bounds here? Do you mean what if the > header data is incorrect?
Yes, that's what I meant. And I'm mainly trying to get some perspective about what kinds of checking we should be doing. In this case, it seems that we don't actually need anything more than what you already have, so we're all good here. thanks, -- John Hubbard
