[PATCH 09/10] cli/count: update to use notmuch_query_search_messages_st

[David Bremner]

This brings back status information that may have been hidden by the
great library logging conversion.
---
 notmuch-count.c    | 16 ++++++++++------
 test/T060-count.sh | 30 ++++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 6 deletions(-)

diff --git a/notmuch-count.c b/notmuch-count.c
index 57a88a8..25b05df 100644
--- a/notmuch-count.c
+++ b/notmuch-count.c
@@ -33,17 +33,18 @@ enum {
     EXCLUDE_FALSE,
 };

-static unsigned int
+static int
 count_files (notmuch_query_t *query)
 {
     notmuch_messages_t *messages;
     notmuch_message_t *message;
     notmuch_filenames_t *filenames;
-    unsigned int count = 0;
+    notmuch_status_t status;
+    int count = 0;

-    messages = notmuch_query_search_messages (query);
-    if (messages == NULL)
-       return 0;
+    status = notmuch_query_search_messages_st (query, &messages);
+    if (print_status_query ("notmuch count", query, status))
+       return -1;

     for (;
         notmuch_messages_valid (messages);
@@ -71,6 +72,7 @@ print_count (notmuch_database_t *notmuch, const char 
*query_str,
 {
     notmuch_query_t *query;
     size_t i;
+    int count;

     query = notmuch_query_create (notmuch, query_str);
     if (query == NULL) {
@@ -89,7 +91,9 @@ print_count (notmuch_database_t *notmuch, const char 
*query_str,
        printf ("%u\n", notmuch_query_count_threads (query));
        break;
     case OUTPUT_FILES:
-       printf ("%u\n", count_files (query));
+       count = count_files (query);
+       if (count >= 0)
+           printf ("%u\n", count);
        break;
     }

diff --git a/test/T060-count.sh b/test/T060-count.sh
index da86c8c..973a42d 100755
--- a/test/T060-count.sh
+++ b/test/T060-count.sh
@@ -93,5 +93,35 @@ notmuch count --output=messages >>EXPECTED
 notmuch count --output=messages tag:inbox >>EXPECTED
 test_expect_equal_file EXPECTED OUTPUT

+backup_database
+test_begin_subtest "error message for database open"
+dd if=/dev/zero of="${MAIL_DIR}/.notmuch/xapian/postlist.DB" count=3
+notmuch count '*' 2>OUTPUT 1>/dev/null
+output=$(sed 's/^\(A Xapian exception [^:]*\):.*$/\1/' OUTPUT)
+test_expect_equal "${output}" "A Xapian exception occurred opening database"
+restore_database
+
+cat <<EOF > count-files.gdb
+set breakpoint pending on
+break count_files
+commands
+shell cp /dev/null ${MAIL_DIR}/.notmuch/xapian/postlist.DB
+continue
+end
+run
+EOF
+
+backup_database
+test_begin_subtest "error message from query_search_messages"
+gdb --batch-silent --return-child-result -x count-files.gdb \
+    --args notmuch count --output=files '*' 2>OUTPUT 1>/dev/null
+cat <<EOF > EXPECTED
+notmuch count: A Xapian exception occurred
+A Xapian exception occurred performing query
+Query string was: *
+EOF
+sed 's/^\(A Xapian exception [^:]*\):.*$/\1/' < OUTPUT > OUTPUT.clean
+test_expect_equal_file EXPECTED OUTPUT.clean
+restore_database

 test_done
-- 
2.1.4