On Tue, 24 Jan 2012 19:45:18 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote: > 1. rename notmuch-test-compare to notmuch-test-expect-equal
I'll change this. > 2. move the top level equal check to the non-list branch I'd rather not change this, though I'll write some commentary to explain how things are. > But both of these are subjective and minor, so I leave it to David to > decide whether to change or ignore them. Otherwise, the patch looks > good to me. > > While replying to this email, I noticed a trailing whitespace. I may > have missed them in other patches. David, can you please check for > trailing white spaces and clean them? Yes. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120124/aa46b6bd/attachment.pgp>
