On Mon, 16 Jan 2012 21:41:09 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote: > On Mon, 16 Jan 2012 16:47:33 +0000, David Edmondson <dme at dme.org> wrote: > > --- > > > > Add three tests. The third one currently fails. > > > > I do not like that we add testing code to emacs/ folder. My > understanding is that files in emacs/ are all intended to be installed > on the system. But tests should not be. Can we move this file to > tests/? > > Also, one file for all tests is a mess. Let's write more smaller files > that test different features instead of putting everything to one > bloated file. Like we do for other tests now. > > I like the idea of putting elisp testing code into .el files and calling > functions from regular tests (that is why I added test-lib.el). For > tests implemented in elisp, I propose adding a pair of files, e.g.: > > tests/emacs-address.sh - tests that call elisp functions > tests/emacs-address.el - elisp code that actually implements the tests > > What do you think?
All good suggestions - I'll re-whack it. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120116/1f30ad7d/attachment.pgp>
