On Tue, Dec 08 2015, David Bremner <[email protected]> wrote: > Tomi Ollila <[email protected]> writes: > >> Some compilers (older than gcc 4.5 and clang 2.9) do support >> __attribute__ ((deprecated)) but not >> __attribute__ ((deprecated("message"))). >> >> Check (clang) and know (gcc) which versions support which variants >> and make two definitions of define NOTMUCH_DEPRECATED macro; >> one with and and one without the ("message") part. >> >> __has_extension() replacement was modeled after __has_attribute() >> definition in compat/function-attributes.h. Thanks Justus. > > Hi Tomi; > > I keep coming back to review this patch, but I'm blocked by the fact > that clang++ is broken on Debian (and lots of other places, I guess) for > months. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038
Personally I am not fond of the commit message but I don't want to emphasize the change by sending an updated one. We could move it to *moreinfo* to get it out of our ways for the time being -- and see whether things stabilize (to one way or another) to decide whether to push this further. > > d Tomi _______________________________________________ notmuch mailing list [email protected] https://notmuchmail.org/mailman/listinfo/notmuch
