On Mon, 09 Jan 2012 00:02:20 -0500, Aaron Ecay <[email protected]> wrote: > On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins > <[email protected]> wrote: > > On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay <[email protected]> wrote: > > > > > > - It would be good to make show-next &optional. This will enable code > > > to call the fn with only two arguments, and not showing next will be > > > the default behavior. > > > > That's a nice idea. Probably better for a separate patch, though. > > This patch introduces show-next as a new argument to the function. So it > can and should make it &optional, if that is the appropriate semantics > for it to have.
Actually, the show-next argument was already part of the function. I
did not introduce it. And it wasn't optional originally, so if we want
to change that behavior we should probably do so in a separate patch.
> That said, here’s an alternate proposal: provide two functions as the
> “external” API, namely ‘notmuch-show-{add,remove}-tag-thread’ (by
> parallelism with ‘notmuch-show-{add,remove}-tag’). These could be
> thin wrappers around ‘notmuch-show-tag-thread-internal’, which would
> then not be intended to be called by user code.
I think that's a better idea. In the next version I'll add something
like this instead.
jamie.
pgpJAsOUWyEHn.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
