ctubbsii commented on code in PR #2293:
URL: https://github.com/apache/zookeeper/pull/2293#discussion_r2275011963
##########
zookeeper-server/pom.xml:
##########
@@ -75,12 +75,8 @@
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-core</artifactId>
- </dependency>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-classic</artifactId>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
Review Comment:
Since `slf4j-simple` is not listed in the `zookeeper-assembly/pom.xml`, it
is assumed to be picked up automatically as a transitive dependency of the
`zookeeper-server` module (artifactId: zookeeper). So, using test scope or
optional won't work, because the intent is that it will automatically get
picked up transitively for the assembly. I still think test scope is most
appropriate, so the fix would be to explicitly add slf4j-simple to the
`zookeeper-assembly/pom.xml`, so it will be included in the assembly directly,
rather than transitively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
