kezhuw commented on PR #2209: URL: https://github.com/apache/zookeeper/pull/2209#issuecomment-2507215294
> certstr is not serving it's purpose (to hold the entire cert string as-is) I don't think there is such a purpose. I pointed out this. > certstr is only used in free(zh->fd->cert->certstr). I think it serves as a way to pass multiple ssl related parameters. After zookeeper_init_ssl, it is done and should never be used until free. If zcert_t is a strong encapsulated struct, than certstr should not be exposed. -- https://github.com/apache/zookeeper/pull/2209#issuecomment-2461388919 >> With the suggested change, both zcert.certstr and zcert.ca will point to 'server.crt', as follows, > > Does it matter if we never use certstr as const char* ? -- https://github.com/apache/zookeeper/pull/2209#issuecomment-2466111427 > This is still not correct Nothing incorrect. It would be nice if we change `char *certstr` in `zcert_t` to `void * certbuf`, so no one will misuse it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
