kezhuw commented on code in PR #2205:
URL: https://github.com/apache/zookeeper/pull/2205#discussion_r1818350322
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java:
##########
@@ -2375,7 +2375,7 @@ public boolean authWriteRequest(Request request) {
try {
request.cnxn.sendResponse(rh, null, null);
} catch (IOException e) {
- LOG.error("IOException : {}", e);
+ LOG.error("IOException", e);
Review Comment:
```suggestion
LOG.warn("IOException", e);
```
`error` with exception stacktrace panics, a client connection io error does
not deserve that.
Currently, the handling of `sendResponse` is not consistent. I checked the
code, and found no `IOException`. We probably should revise and figure out how
to handle client connection error in a consistent way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
