jonmv commented on code in PR #2154:
URL: https://github.com/apache/zookeeper/pull/2154#discussion_r1767017726
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java:
##########
@@ -152,24 +152,25 @@ protected void unregisterJMX(Learner peer) {
}
@Override
- public synchronized void shutdown() {
+ public synchronized void shutdown(boolean fullyShutDown) {
if (!canShutdown()) {
+ super.shutdown(fullyShutDown);
LOG.debug("ZooKeeper server is not running, so not proceeding to
shutdown!");
return;
}
Review Comment:
I'm sure we could do this better, yes :) I'll give it a stab tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
