AlphaCanisMajoris commented on PR #1848: URL: https://github.com/apache/zookeeper/pull/1848#issuecomment-2007575274
> This should be superceded by #2111. Both try to log diff entries synchronous before NEWLEADER ack and #2028 is similar. Additionally, #2111 should fix [ZOOKEEPER-4643](https://issues.apache.org/jira/browse/ZOOKEEPER-4643) also. That's cool. The code fix of #2111 is basically the same as that of #2028. It should fix [ZOOKEEPER-4643](https://issues.apache.org/jira/browse/ZOOKEEPER-4643), [ZOOKEEPER-4646](https://issues.apache.org/jira/browse/ZOOKEEPER-4646) and [ZOOKEEPER-4685](https://issues.apache.org/jira/browse/ZOOKEEPER-4685). > I am not sure `testNormalFollowerRunWithDiff` is still flaky or not. I will check it later. No sure it is worth to revert it to pre [ZOOKEEPER-2678](https://issues.apache.org/jira/browse/ZOOKEEPER-2678) given my [comments](https://issues.apache.org/jira/browse/ZOOKEEPER-3023?focusedCommentId=17516241&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17516241) in [ZOOKEEPER-3023](https://issues.apache.org/jira/browse/ZOOKEEPER-3023). In my understanding, #2111 cannot avoid the issue [ZOOKEEPER-4394](https://issues.apache.org/jira/browse/ZOOKEEPER-4394), right? Not all the pending requests need to be logged before the follower replies ACK of NEWLEADER. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
