fanyang89 commented on code in PR #2139:
URL: https://github.com/apache/zookeeper/pull/2139#discussion_r1525732277
##########
zookeeper-client/zookeeper-client-c/src/mt_adaptor.c:
##########
@@ -479,8 +480,9 @@ void *do_completion(void *v)
pthread_mutex_unlock(&zh->completions_to_process.lock);
process_completions(zh);
}
- api_epilog(zh, 0);
- LOG_DEBUG(LOGCALLBACK(zh), "completion thread terminated");
Review Comment:
Indeed, it would be conventional to log first and then `api_epilog()`.
But `api_epilog()` does `zookeeper_close()` when the rc is zero, i.e. the
completion thread is still running after the "terminated" output, which could
lead to confusion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
