ctubbsii commented on code in PR #2118:
URL: https://github.com/apache/zookeeper/pull/2118#discussion_r1471502288
##########
zookeeper-server/src/main/resources/lib/netty-codec-4.1.105.Final.LICENSE.txt:
##########
@@ -1,7 +1,7 @@
Apache License
Version 2.0, January 2004
- http://www.apache.org/licenses/
+ https://www.apache.org/licenses/
Review Comment:
It looks like the netty repo includes these changes, from
https://github.com/netty/netty/pull/10708
I'm not really sure why we're bundling so many copies of the Apache License
anyway. The project as a whole is under the Apache License. Portions of the
project, like certain bundled dependencies, may be available under a different
license, so it makes sense to include those when that's the case, but when it's
Apache, there's not really a need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
