anmolnar commented on PR #1298: URL: https://github.com/apache/zookeeper/pull/1298#issuecomment-1814752884
I changed my mind, implementing the parent ACL check doesn't make much sense. The same 'scan' issue can be achieved with get too: ``` /a - protected /a/b - protected /a/c - not protected /a/d - not exist ``` Scanning with get: ``` [zk: localhost:2181(CONNECTED) 9] ls /a Authentication is not valid : /a [zk: localhost:2181(CONNECTED) 10] get /a/b org.apache.zookeeper.KeeperException$NoAuthException: KeeperErrorCode = NoAuth for /a/b [zk: localhost:2181(CONNECTED) 11] get /a/c null [zk: localhost:2181(CONNECTED) 12] get /a/d org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /a/d ``` There's no point fixing exists() recursively. ZooKeeper ACLs are not recursive means that such protection against scanning attacks cannot be provided. I tend to accept @maoling 's patch as it is, because doing anything more will increase complexity without adding value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
